Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid disabling prettier #6079

Merged
merged 1 commit into from Jun 23, 2020
Merged

chore: avoid disabling prettier #6079

merged 1 commit into from Jun 23, 2020

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 23, 2020

No description provided.

@googlebot googlebot added the cla: yes label Jun 23, 2020
@jackfranklin jackfranklin requested review from mathiasbynens and paullewis Jun 23, 2020
@jackfranklin
Copy link
Collaborator Author

jackfranklin commented Jun 23, 2020

@paullewis PTAL. This worked fine for me with no extra changes. I think locally you might be on an old Prettier? Please make sure your editor is using the one from the node_modules of this package.

@jackfranklin jackfranklin force-pushed the avoid-prettier-issue branch from 8852b03 to cb2cd53 Jun 23, 2020
@jackfranklin jackfranklin force-pushed the avoid-prettier-issue branch from cb2cd53 to 3fff181 Jun 23, 2020
@jackfranklin jackfranklin merged commit 1ee379c into main Jun 23, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the avoid-prettier-issue branch Jun 23, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.