Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declare `toBeGolden` to TypeScript #6080

Merged
merged 1 commit into from Jun 23, 2020
Merged

chore: declare `toBeGolden` to TypeScript #6080

merged 1 commit into from Jun 23, 2020

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 23, 2020

Which means we can avoid all the ts-expect-errors on any toBeGolden
calls.

@googlebot googlebot added the cla: yes label Jun 23, 2020
@jackfranklin jackfranklin requested a review from OrKoN Jun 23, 2020
@OrKoN
OrKoN approved these changes Jun 23, 2020
Which means we can avoid all the ts-expect-errors on any `toBeGolden`
calls.
@jackfranklin jackfranklin force-pushed the fix-to-be-golden branch from 2233368 to 6218f74 Jun 23, 2020
@jackfranklin jackfranklin merged commit 381b0f8 into main Jun 23, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the fix-to-be-golden branch Jun 23, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Which means we can avoid all the ts-expect-errors on any `toBeGolden`
calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.