Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ESLint violation and lessen rule strictness #6081

Merged
merged 6 commits into from Jun 23, 2020
Merged

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 23, 2020

No description provided.

@googlebot googlebot added the cla: yes label Jun 23, 2020
@jackfranklin jackfranklin requested a review from paullewis Jun 23, 2020
@@ -100,6 +100,11 @@ module.exports = {
"@typescript-eslint/semi": 2,
"@typescript-eslint/no-empty-function": 0,
"@typescript-eslint/no-use-before-define": 0,
// We have to use any on some types so the warning isn't valuable.

This comment has been minimized.

Copy link
@paullewis

paullewis Jun 23, 2020

Collaborator

:(

This comment has been minimized.

Copy link
@jackfranklin

jackfranklin Jun 23, 2020

Author Collaborator

Yeah :( Long term we'll use the TS compiler strictness options to get rid of this but these warnings are adding no value.

@@ -67,7 +67,7 @@ describe('Emulation', () => {
function dispatchTouch() {
let fulfill;
const promise = new Promise((x) => (fulfill = x));
window.ontouchstart = function (e) {
window.ontouchstart = () => {

This comment has been minimized.

Copy link
@paullewis

paullewis Jun 23, 2020

Collaborator

But why though?

This comment has been minimized.

Copy link
@jackfranklin

jackfranklin Jun 23, 2020

Author Collaborator

the majority of the codebase + tests use arrow functions - this one stood out to me so I just swapped it out

Copy link
Collaborator

paullewis left a comment

LGTM with curiosity question

@jackfranklin jackfranklin force-pushed the eslint-fixes branch from e5085ea to 10dc654 Jun 23, 2020
@jackfranklin jackfranklin merged commit 70a900e into main Jun 23, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@mathiasbynens mathiasbynens deleted the eslint-fixes branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.