Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): remove `emulateMedia` method #6084

Merged
merged 1 commit into from Jun 23, 2020
Merged

feat(api): remove `emulateMedia` method #6084

merged 1 commit into from Jun 23, 2020

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 23, 2020

It has been deprecated for a while. In the next breaking release let's remove it.

@googlebot googlebot added the cla: yes label Jun 23, 2020
@jackfranklin jackfranklin requested a review from mathiasbynens Jun 23, 2020
@mathiasbynens
Copy link
Member

mathiasbynens commented Jun 23, 2020

Let's mark this as feat(api): and make sure to include "BREAKING CHANGE" in the commit message, per https://github.com/puppeteer/puppeteer/blob/main/CONTRIBUTING.md#commit-messages.

@jackfranklin jackfranklin force-pushed the drop-emulate-media branch from 1b26e4f to 5c157f5 Jun 23, 2020
@jackfranklin jackfranklin changed the title chore: remove `emulateMedia` method feat(api): remove `emulateMedia` method Jun 23, 2020
It has been deprecated for a while. In the next breaking release let's remove it.

BREAKING CHANGE: swap to `emulateMediaType` instead.
@jackfranklin jackfranklin force-pushed the drop-emulate-media branch from 5c157f5 to 6c1184b Jun 23, 2020
@jackfranklin jackfranklin merged commit 37f6032 into main Jun 23, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the drop-emulate-media branch Jun 23, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
It has been deprecated for a while. In the next breaking release let's remove it.

BREAKING CHANGE: swap to `emulateMediaType` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.