Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): migrate HTTPResponse docs to TSDoc #6085

Merged
merged 2 commits into from Jun 25, 2020
Merged

Conversation

@hanselfmu
Copy link
Collaborator

hanselfmu commented Jun 23, 2020

No description provided.

Changhao Han
@hanselfmu hanselfmu requested review from mathiasbynens and jackfranklin Jun 23, 2020
@googlebot googlebot added the cla: yes label Jun 23, 2020
ok(): boolean {
// TODO: document === 0 case?

This comment has been minimized.

Copy link
@jackfranklin

jackfranklin Jun 23, 2020

Collaborator

@mathiasbynens do you have any context to this case? I'm not sure why we'd have this.

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Jun 23, 2020

Member

I don't know, but I would guess this is used for errors before we can even get an HTTP response + status code, e.g. certificate issues. Maybe @sigurdschneider knows?

Copy link
Collaborator

jackfranklin left a comment

Minor comments, looks great on the whole, thank you!

Changhao Han
@jackfranklin jackfranklin self-requested a review Jun 24, 2020
Copy link
Collaborator

jackfranklin left a comment

This looks good to me ! If we're not sure on the status code 0 case, happy to merge as is.

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 25, 2020

I'm going to merge this, and we can make another PR to address the status = 0 case.

@jackfranklin jackfranklin merged commit c7851e8 into main Jun 25, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the tsdoc-httpresponse branch Jun 25, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Co-authored-by: Changhao Han <changhaohan@chromium.org>
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Co-authored-by: Changhao Han <changhaohan@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.