Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up TODO from TS tests migration #6090

Merged
merged 1 commit into from Jun 24, 2020
Merged

chore: tidy up TODO from TS tests migration #6090

merged 1 commit into from Jun 24, 2020

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 24, 2020

This line is needed to purposefully test that asElement works even
when the main Node class has been deleted by the user.

@googlebot googlebot added the cla: yes label Jun 24, 2020
@jackfranklin jackfranklin requested a review from OrKoN Jun 24, 2020
@OrKoN
OrKoN approved these changes Jun 24, 2020
Deleting `Node` errors in strict mode; we don't need to have this test
any more.
@jackfranklin jackfranklin force-pushed the test-tidying branch from 3b79651 to 3512c0d Jun 24, 2020
@jackfranklin jackfranklin merged commit 9224251 into main Jun 24, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@jackfranklin jackfranklin deleted the test-tidying branch Jun 24, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Deleting `Node` errors in strict mode; we don't need to have this test
any more.
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Deleting `Node` errors in strict mode; we don't need to have this test
any more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.