Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add TSDoc to ExecutionContext #6094

Merged
merged 1 commit into from Jun 24, 2020
Merged

Conversation

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 24, 2020

No description provided.

Copy link
Collaborator

hanselfmu left a comment

LGTM

@jackfranklin jackfranklin force-pushed the tsdoc-execution-context branch from d7828e4 to 1633d24 Jun 24, 2020
@googlebot
Copy link

googlebot commented Jun 24, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 24, 2020
@jackfranklin jackfranklin added cla: yes and removed cla: no labels Jun 24, 2020
@googlebot
Copy link

googlebot commented Jun 24, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jackfranklin jackfranklin merged commit b850ac2 into main Jun 24, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
@jackfranklin jackfranklin deleted the tsdoc-execution-context branch Jun 24, 2020
mathiasbynens added a commit that referenced this pull request Jun 25, 2020
Co-authored-by: Martin Splitt <mr.avgp@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.