Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): migrate Page.ts to TSDoc (part 0 / 2) #6104

Merged
merged 6 commits into from Jun 26, 2020
Merged

docs(new): migrate Page.ts to TSDoc (part 0 / 2) #6104

merged 6 commits into from Jun 26, 2020

Conversation

@hanselfmu
Copy link
Collaborator

hanselfmu commented Jun 25, 2020

I'm breaking down the entire migration into three parts. This is the first part.

/**
* Sets the page's geolocation.
*
* * @remarks Consider using {@link BrowserContext.overridePermissions} to

This comment has been minimized.

Copy link
@jackfranklin

jackfranklin Jun 25, 2020

Collaborator

You've got an extra * here before @remarks

This comment has been minimized.

Copy link
@hanselfmu

hanselfmu Jun 25, 2020

Author Collaborator

Thanks for noticing! Removed it.

Copy link
Collaborator

jackfranklin left a comment

Tiny nitpick, otherwise this looks great! Thank you :)

Changhao Han added 5 commits Jun 25, 2020
Changhao Han
Changhao Han
Changhao Han
Changhao Han
@hanselfmu hanselfmu merged commit adeffba into main Jun 26, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@hanselfmu hanselfmu deleted the tsdoc-page-0 branch Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.