Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): Add TSDoc to Coverage class #6106

Merged
merged 5 commits into from Jun 29, 2020
Merged

Conversation

@hashseed
Copy link
Collaborator

hashseed commented Jun 25, 2020

No description provided.

@hashseed hashseed requested a review from jackfranklin Jun 25, 2020
@googlebot googlebot added the cla: yes label Jun 25, 2020
src/common/Coverage.ts Outdated Show resolved Hide resolved
src/common/Coverage.ts Outdated Show resolved Hide resolved
@hashseed
Copy link
Collaborator Author

hashseed commented Jun 25, 2020

Please re-review :)

@jackfranklin
Copy link
Collaborator

jackfranklin commented Jun 29, 2020

@hashseed LGTM! I think after you merged in main you need to re-generate the docs and then CI will be happy.

@jackfranklin jackfranklin self-requested a review Jun 29, 2020
hashseed added 5 commits Jun 25, 2020
@hashseed hashseed force-pushed the hashseed:coverage branch from 648d082 to a45bfe5 Jun 29, 2020
@jackfranklin jackfranklin merged commit 123c377 into puppeteer:main Jun 29, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.