fix: configure debug logging in browser #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node debug library uses the `DEBUG` environment variable to configure what gets logged. Our browser version just logs everything; this commit changes it to look for `window.__PUPPETEER_DEBUG` and matches the behaviour accordingly: * If the value is not set, nothing is logged. * If the value is set to `*` everything is logged. * If the value is set to a string `foo`, messages with that prefix are logged. * If the value is set to a string ending in `*`, e.g. `foo*`, messages with prefixes that start with `foo` are logged.
|
Do you want any tests for this? |
paullewis
approved these changes
Jul 20, 2020
|
@paullewis , yes but we can't yet until we have browser test frameworks set up. Which is on the agnostification list of work to be done. |
|
@jackfranklin would you mind giving feedback on #5786 I would love for Puppeteer to provide even more insights about what it is doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Node debug library uses the
DEBUGenvironment variable toconfigure what gets logged. Our browser version just logs everything;
this commit changes it to look for
window.__PUPPETEER_DEBUGand matches the behaviour accordingly:*everything is logged.foo, messages with that prefix arelogged.
*, e.g.foo*, messageswith prefixes that start with
fooare logged.