New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change QueryHandler to contain QueryOne and QueryAll methods #6218
feat: change QueryHandler to contain QueryOne and QueryAll methods #6218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but I'll await Mathias' approval.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Johan!
@@ -34,7 +35,7 @@ export function registerCustomQueryHandler( | |||
if (!isValidName) | |||
throw new Error(`Custom query handler names may only contain [a-zA-Z]`); | |||
|
|||
_customQueryHandlers.set(name, handler as QueryHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work getting rid of this as
:)
divs.map((d) => d.textContent).join('') | ||
); | ||
expect(txtContents).toBe('textcontent'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with one question about the change of type to Function
and if we can avoid it.
Summary of changes: The api for custom query handlers is unchanged:
but
|
Discussed with Paul offline. He's fine with this, so not blocking on his review+ bit. |
Extends #5753 with support for registering both
$
and$$
handlers under the same selection prefix, i.emyCustomQueryHandlerPrefix/<selector>
.