Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): launcher.launch() should pass 'timeout' option #5180 #7596

Merged
merged 6 commits into from Sep 27, 2021
Merged

Conversation

@jschfflr
Copy link
Contributor

@jschfflr jschfflr commented Sep 23, 2021

This is a reland of #5180 as the fork has already been deleted and can no longer be used to fix the merge conflicts.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 23, 2021
@jschfflr jschfflr added cla: yes and removed cla: no labels Sep 23, 2021
@googlebot
Copy link

@googlebot googlebot commented Sep 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Sep 23, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jschfflr
Copy link
Contributor Author

@jschfflr jschfflr commented Sep 23, 2021

Adding cla:yes as the author gave their consent on #5180 already.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 23, 2021
@jschfflr jschfflr requested a review from OrKoN Sep 23, 2021
OrKoN
OrKoN approved these changes Sep 27, 2021
@jschfflr jschfflr added cla: yes and removed cla: no labels Sep 27, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Sep 27, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jschfflr jschfflr merged commit 113489d into main Sep 27, 2021
6 checks passed
@jschfflr jschfflr deleted the pr5180 branch Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants