Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix BrowserFetcher._getFolderPath to support relative install paths #7613

Merged
merged 3 commits into from Sep 29, 2021

Conversation

@nadir
Copy link
Contributor

@nadir nadir commented Sep 29, 2021

This patch fixes the BrowserFetcher._getFolderPath method so that it supports relative download paths using PUPPETEER_DOWNLOAD_PATH or npm config

Issues: #7592

This patch fixes the BrowserFetcher._getFolderPath method so that it supports relative download paths using PUPPETEER_DOWNLOAD_PATH or npm config

Issues: puppeteer#7592
@google-cla
Copy link

@google-cla google-cla bot commented Sep 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 29, 2021
@nadir
Copy link
Contributor Author

@nadir nadir commented Sep 29, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 29, 2021
src/node/BrowserFetcher.ts Outdated Show resolved Hide resolved
@jschfflr
Copy link
Contributor

@jschfflr jschfflr commented Sep 29, 2021

@nadhirhb Thanks for your contribution!

This patch fixes the BrowserFetcher._getFolderPath method so that it supports relative download paths using PUPPETEER_DOWNLOAD_PATH or npm config

Issues: puppeteer#7592
@jschfflr jschfflr enabled auto-merge (squash) Sep 29, 2021
@jschfflr jschfflr merged commit eebf452 into puppeteer:main Sep 29, 2021
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants