Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add webp to screenshot quality option allow list #7631

Merged
merged 3 commits into from Oct 7, 2021

Conversation

@tjunnone
Copy link
Contributor

@tjunnone tjunnone commented Oct 5, 2021

#7565 added webp image format support to the Page.screenshot API, but did not add webp to the list of formats that can use the "quality" option. Specifying the quality option now throws "options.quality is unsupported for the webp screenshots".

This PR allows properly passing through the screenshot quality option from Puppeteer to the browser as expected.

This allows passing through the screenshot quality option from Puppeteer to Chrome
when using the WebP image format
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
Copy link
Contributor

@jschfflr jschfflr left a comment

Thanks for catching this @tjunnone!

@jschfflr jschfflr enabled auto-merge (squash) Oct 6, 2021
@jschfflr jschfflr merged commit b20c2bf into puppeteer:main Oct 7, 2021
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants