Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle unhandled promise rejections in tests #7722

Merged
merged 7 commits into from Oct 27, 2021

Conversation

@jschfflr
Copy link
Contributor

@jschfflr jschfflr commented Oct 25, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 25, 2021
@jschfflr jschfflr requested a review from OrKoN Oct 25, 2021
package.json Outdated Show resolved Hide resolved
@puppeteer puppeteer deleted a comment from GetBentGaming Oct 26, 2021
@puppeteer puppeteer deleted a comment from GetBentGaming Oct 26, 2021
@jschfflr jschfflr requested a review from OrKoN Oct 26, 2021
@jschfflr jschfflr enabled auto-merge (squash) Oct 26, 2021
@jschfflr jschfflr disabled auto-merge Oct 26, 2021
@jschfflr jschfflr enabled auto-merge (squash) Oct 26, 2021
OrKoN
OrKoN approved these changes Oct 27, 2021
@jschfflr jschfflr merged commit 07febca into main Oct 27, 2021
6 checks passed
@jschfflr jschfflr deleted the unhandled-promise-rejections branch Oct 27, 2021
@GetBentGaming
Copy link

@GetBentGaming GetBentGaming commented Oct 27, 2021

Hello I'm still trying to fix Puppateers mess ups on my computer

@GetBentGaming
Copy link

@GetBentGaming GetBentGaming commented Oct 27, 2021

He keeps changing my elements

@GetBentGaming
Copy link

@GetBentGaming GetBentGaming commented Oct 27, 2021

How !!!!!

@jschfflr
Copy link
Contributor Author

@jschfflr jschfflr commented Oct 27, 2021

@GetBentGaming Feel free to create an issue and to describe your situation there. Happy to take a look if it's something caused by Puppeteer itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants