Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: strict mode fixes for HTTPRequest/Response classes

Merged
merged 1 commit into from May 5, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented May 2, 2022

Solves type issues in HTTPRequest/Response with some slight changes in the behaviour and API.

Issues #6769

@OrKoN OrKoN requested a review from ergunsh May 2, 2022
@OrKoN OrKoN force-pushed the strict-mode-requests branch 2 times, most recently from 753ea0e to de44d9c Compare May 2, 2022
src/common/HTTPRequest.ts Outdated Show resolved Hide resolved
src/common/HTTPRequest.ts Outdated Show resolved Hide resolved
src/common/HTTPRequest.ts Outdated Show resolved Hide resolved
src/common/HTTPRequest.ts Outdated Show resolved Hide resolved
src/common/HTTPRequest.ts Show resolved Hide resolved
src/common/HTTPResponse.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN force-pushed the strict-mode-requests branch from de44d9c to e00d98c Compare May 4, 2022
@OrKoN OrKoN changed the title fix: strict mode fixes for HTTPRequest/Response classes fix!: strict mode fixes for HTTPRequest/Response classes May 4, 2022
@OrKoN OrKoN force-pushed the strict-mode-requests branch from e00d98c to 53c0394 Compare May 4, 2022
ergunsh
ergunsh approved these changes May 4, 2022
Copy link
Collaborator

@ergunsh ergunsh left a comment

Code changes LGTM with 1 comment on STATUS_TEXTS and response typing.

Apart from that, I had a comment on the nature of introducing breaking changes in a minor version and I don't have a strong opinion on that one. If you think that is acceptable, this is good to go! 🥳

@OrKoN OrKoN force-pushed the strict-mode-requests branch from 53c0394 to 964ea8e Compare May 4, 2022
Solves type issues in HTTPRequest/Response with some slight changes in the behaviour and API.

Issues #6769
@OrKoN OrKoN force-pushed the strict-mode-requests branch from 964ea8e to 3d2541a Compare May 5, 2022
@OrKoN OrKoN enabled auto-merge (squash) May 5, 2022
@OrKoN OrKoN disabled auto-merge May 5, 2022
@OrKoN OrKoN enabled auto-merge (squash) May 5, 2022
@OrKoN OrKoN merged commit 2804ae8 into main May 5, 2022
10 checks passed
@OrKoN OrKoN deleted the strict-mode-requests branch May 5, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants