Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ES modules #8306

Merged
merged 2 commits into from May 9, 2022
Merged

feat: support ES modules #8306

merged 2 commits into from May 9, 2022

Conversation

jrandolf
Copy link
Collaborator

@jrandolf jrandolf commented May 3, 2022

No description provided.

@jrandolf jrandolf force-pushed the esm_support branch 4 times, most recently from fbd5b29 to db42e8f Compare May 3, 2022
@jrandolf jrandolf requested a review from OrKoN May 3, 2022
@jrandolf jrandolf force-pushed the esm_support branch 2 times, most recently from e2785cc to cf1839b Compare May 3, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented May 4, 2022

Let's also involve @ergunsh in the review as we all need to support this going forward :)

src/constants.ts Outdated Show resolved Hide resolved
scripts/test-install.sh Show resolved Hide resolved
@jrandolf jrandolf force-pushed the esm_support branch 4 times, most recently from 8193f7a to 586b5db Compare May 5, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented May 6, 2022

Pls remove puppeteer-13.7.0-post.tgz (it seems it got committed somehow)

src/generated/version.ts.tmpl Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/generated/version.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@ergunsh ergunsh left a comment

LGTM with a few comments & questions. Leaving approval to @OrKoN :)

compat/esm/compat.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/generated/version.ts.tmpl Outdated Show resolved Hide resolved
scripts/test-install.sh Show resolved Hide resolved
@jrandolf jrandolf force-pushed the esm_support branch 3 times, most recently from 818cb76 to 76dafa6 Compare May 6, 2022
scripts/test-install.sh Show resolved Hide resolved
scripts/test-install.sh Show resolved Hide resolved
@jrandolf jrandolf force-pushed the esm_support branch 2 times, most recently from b618570 to 2f511fa Compare May 6, 2022
OrKoN
OrKoN approved these changes May 9, 2022
@jrandolf jrandolf enabled auto-merge (squash) May 9, 2022
@jrandolf jrandolf merged commit 6841bd6 into main May 9, 2022
10 checks passed
@jrandolf jrandolf deleted the esm_support branch May 9, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants