Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If currentNode and root are the same, do not include them in the result

Merged
merged 3 commits into from May 11, 2022

Conversation

Pirikara
Copy link
Contributor

@Pirikara Pirikara commented May 11, 2022

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
n/a

Summary
fix for #8331

Does this PR introduce a breaking change?
no

Other information

@google-cla
Copy link

google-cla bot commented May 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@OrKoN OrKoN requested a review from johanbay May 11, 2022
Copy link
Collaborator

@johanbay johanbay left a comment

LGTM, thanks!

@jrandolf jrandolf enabled auto-merge (squash) May 11, 2022
@jrandolf jrandolf merged commit a61144d into puppeteer:main May 11, 2022
10 checks passed
@Pirikara Pirikara deleted the fix-pierce-handler branch May 11, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants