Move logic about where reports dir is

[danieldreier]

Makes more sense in params.pp than as the only thing in reports.pp
Doesn't need to be a conditional anymore if we're dropping 2.x support
(also highlights that it's probably wrong on *BSD)

[igalic]

why not keep it as puppet::reports_dir, and overwriteable via init.pp?

[danieldreier]

@igalic I've reorganized it into puppet::server::report_dir with defaults provided from puppet::params::report_dir because I believe we'll want to provide different report dirs for different operating systems. I'm not sure where those reports live on *BSD but I'll bet it's not the same place as they do in the Linux distros.

I'm also hoping to add support for managing Puppet Enterprise, which locates everything in /opt. My thinking is that putting defaults in params will make sense for that, but having puppet::server::report_dir makes it easy to override if you want.

Does that work for you? I'm totally open to other solutions, not quite sure what the best way to handle this is.

[igalic]

yup. my thinking was just to drive everything from init, but that doesn't make entirely sense in this case.

[danieldreier]

is this blocking on anything / controversial? I can certainly change the approach (or drop the idea entirely) but would like to know if I'm proposing something problematic or poorly advised.

[igalic]

nope, i think you're on the right track, sorry for the confusion here.