Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Inform users and abort when we can't unpack the ISO image #54

Closed
daniel-pittman opened this Issue · 3 comments

2 participants

@daniel-pittman

When running under fakeroot(1), we would try and loopback mount the ISO image to unpack it despite knowing that could never work. That was a poor user experience, and we can absolutely do better than that.

This updates the script to check if we are running under fakeroot and skip the attempt to use mount in favour of informing the user about what they should do to successfully build.

@daniel-pittman daniel-pittman referenced this issue from a commit in daniel-pittman/Razor-Microkernel
@daniel-pittman daniel-pittman Inform users and abort when we can't unpack the ISO image
When running under fakeroot(1), we would try and loopback mount the ISO image
to unpack it despite knowing that could never work. That was a poor user
experience, and we can absolutely do better than that.

This updates the script to check if we are running under fakeroot and skip the
attempt to use mount in favour of informing the user about what they should do
to successfully build.

This closes issue #54.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
9bd0f1c
@daniel-pittman

This ticket is just a bookkeeping placeholder for the pull request. Please put any comments on the pull request.

@tjmcs
Collaborator

should this issue have been closed when pull request #55 was merged or is it still being left open for some reason, @daniel-pittman?

@daniel-pittman

No, should have closed; alas that it didn't work automagically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.