Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Silence the build process #37

Merged
merged 1 commit into from Jan 8, 2013

Conversation

Projects
None yet
2 participants
Contributor

slippycheeze commented Dec 20, 2012

Now that we are automating the build process, having verbose and human-focused
progress messages from downloads and tar creating result in a much more
difficult to debug build - the errors get drowned in a sea of progress that
nobody watches.

This silences the various tools used to rebuild the ISO image.

Signed-off-by: Daniel Pittman daniel@rimspace.net

Contributor

tjmcs commented Dec 20, 2012

Can we make this an option that the user can choose from the command line? (either a new option to support verbose output for debugging of the script or a new option to silence the noise for those not interested in it...)

Contributor

slippycheeze commented Dec 21, 2012

Can we make this an option that the user can choose from the command line? (either a new option to support verbose output for debugging of the script or a new option to silence the noise for those not interested in it...)

It would be reasonably complex, but possible, I guess. Any specific
reason why these progress displays are useful?

Contributor

tjmcs commented Dec 23, 2012

Personally, I've always been the sort that likes to know that something is happening when a long-running process like the bundle build process is going on. The entire process takes over 10 minutes using my cable-modem connection here at home, and having all of those wget commands running silently (with no feedback) would leave me with no feeling of progress being made. I guess what I'm trying to say is that while I'm more than happy to set things up to run silently, I'd like a "verbose" output option that will let me (and folks like me who would like some feedback) get the feedback I'm looking for as this process is running. Either that, or I'd like a "quiet" option that you can use that will make things run quietly for your automated builds in your CI environment. Either one works for me, but I'd like a way of getting feedback somehow (and not just sit waiting for the command to finish) when I run the build-bundle-file.sh command "by hand". The changes in this pull request don't give me that option.

It really shouldn't be that hard to add...set up a new flag (that makes the output of the shell script either verbose or quiet), then use the setting of that flag to set up a couple of variables that contain the appropriate options for the commands we're trying to make verbose or quiet (one for the wget options and another for the tar options) and use those variables in place of the fixed strings in those commands (throughout the script)...I'm happy to try to put together my own pull request to do it if you want me to, but thought it'd be relatively easy for you to do since you've already identified the commands to make verbose or quiet...

Contributor

slippycheeze commented Dec 26, 2012

That should give you optional verbosity in the build process. Hopefully nobody will ever actually benefit from that, of course - now that we have automated the build process, we shouldn't need anybody else to build the Microkernel, but if they want to they can get verbose output along the way.

(Actually achieving that is probably still a little way off, since we don't yet have an implementation of syncing content from Razor to the MK instance, but when that lands we should have seen the last ever round of users having to build their own MK. :)

@slippycheeze slippycheeze Silence the bundle build process
Now that we are automating the build process, having verbose and human-focused
progress messages from downloads and tar creating result in a much more
difficult to debug build - the errors get drowned in a sea of progress that
nobody watches.

This silences the various tools used to rebuild the ISO image.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>
0f68f60
Contributor

slippycheeze commented Dec 28, 2012

One little typo snuck into the push, no idea how. This should fix that.

@slippycheeze slippycheeze added a commit that referenced this pull request Jan 8, 2013

@slippycheeze slippycheeze Merge pull request #37 from daniel-pittman/feature/master/silence-is-…
…the-element-from-which-great-things-fashion-themselves

Silence the build process
19a11aa

@slippycheeze slippycheeze merged commit 19a11aa into puppetlabs:master Jan 8, 2013

@slippycheeze slippycheeze deleted the slippycheeze:feature/master/silence-is-the-element-from-which-great-things-fashion-themselves branch Jan 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment