Inform users and abort when we can't unpack the ISO image #55

Merged
merged 1 commit into from Feb 7, 2013

Conversation

Projects
None yet
1 participant
@slippycheeze
Contributor

slippycheeze commented Jan 15, 2013

When running under fakeroot(1), we would try and loopback mount the ISO image
to unpack it despite knowing that could never work. That was a poor user
experience, and we can absolutely do better than that.

This updates the script to check if we are running under fakeroot and skip the
attempt to use mount in favour of informing the user about what they should do
to successfully build.

This closes issue #54.

Signed-off-by: Daniel Pittman daniel@rimspace.net

Inform users and abort when we can't unpack the ISO image
When running under fakeroot(1), we would try and loopback mount the ISO image
to unpack it despite knowing that could never work. That was a poor user
experience, and we can absolutely do better than that.

This updates the script to check if we are running under fakeroot and skip the
attempt to use mount in favour of informing the user about what they should do
to successfully build.

This closes issue #54.

Signed-off-by: Daniel Pittman <daniel@rimspace.net>

slippycheeze added a commit that referenced this pull request Feb 7, 2013

Merge pull request #55 from daniel-pittman/feature/master/better-fake…
…root-safety-checks

Inform users and abort when we can't unpack the ISO image

@slippycheeze slippycheeze merged commit 2d84e61 into puppetlabs:master Feb 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment