New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding modulepath to apply_manifest_on #234

Merged
merged 2 commits into from May 5, 2014

Conversation

Projects
None yet
3 participants
@liamjbennett
Contributor

liamjbennett commented May 2, 2014

When running as an agent aka master-less (tested using windows) you need to be able to specify the module path because there isn't one otherwise.

The creation of said directory should occur as part of the puppet_module_install command from beaker-rspec.

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins May 2, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented May 2, 2014

Can one of the admins verify this patch?

@@ -717,6 +717,7 @@ def apply_manifest_on(host, manifest, opts = {}, &block)
args << "--parseonly" if opts[:parseonly]
args << "--trace" if opts[:trace]
args << "--parser future" if opts[:future_parser]
args << "--modulepath #{opts[:modulepath]}" if opts[:modulepath]

This comment has been minimized.

@anodelman

anodelman May 2, 2014

Contributor

Please update the yard docs to indicate this new option.

@anodelman

anodelman May 2, 2014

Contributor

Please update the yard docs to indicate this new option.

This comment has been minimized.

@liamjbennett

liamjbennett May 2, 2014

Contributor

Done.

@liamjbennett

liamjbennett May 2, 2014

Contributor

Done.

anodelman added a commit that referenced this pull request May 5, 2014

@anodelman anodelman merged commit ac676e1 into puppetlabs:master May 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment