New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for windows to install_puppet #236

Merged
merged 2 commits into from May 8, 2014

Conversation

Projects
None yet
3 participants
@liamjbennett
Contributor

liamjbennett commented May 2, 2014

I have added support for windows so that it is possible to test using the msi installation.

I added the opts hash argument in order to get this functionality to work but it could (and should) be also be used to allow centos/debian hosts to install specific versions of puppet.

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins May 2, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented May 2, 2014

Can one of the admins verify this patch?

Show outdated Hide outdated lib/beaker/dsl/install_utils.rb Outdated
elsif host['platform'] =~ /windows/
relver = opts[:version]
on host, "curl -O http://downloads.puppetlabs.com/windows/puppet-#{relver}.msi"
on host, "msiexec /qn /i puppet-#{relver}.msi"

This comment has been minimized.

@anodelman

anodelman May 2, 2014

Contributor

I don't want to hardcode a link - let's pass this in as an option.

@anodelman

anodelman May 2, 2014

Contributor

I don't want to hardcode a link - let's pass this in as an option.

This comment has been minimized.

@liamjbennett

liamjbennett May 2, 2014

Contributor

Do you think we should have defaults though? I can see that the apt and yum repo locations are also hardcoded, do you want to also have them removed at some point?

@liamjbennett

liamjbennett May 2, 2014

Contributor

Do you think we should have defaults though? I can see that the apt and yum repo locations are also hardcoded, do you want to also have them removed at some point?

This comment has been minimized.

@anodelman

anodelman May 5, 2014

Contributor

Fair enough, it does meet the standard of that chunk of code so I'm cool with it.

@anodelman

anodelman May 5, 2014

Contributor

Fair enough, it does meet the standard of that chunk of code so I'm cool with it.

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins May 6, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented May 6, 2014

Can one of the admins verify this patch?

anodelman added a commit that referenced this pull request May 8, 2014

Merge pull request #236 from liamjbennett/windows_instalpuppet
adding support for windows to install_puppet

@anodelman anodelman merged commit aae9582 into puppetlabs:master May 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment