New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to vagrant for box_version and box_check_update. #418

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
4 participants
@liamjbennett
Contributor

liamjbennett commented Aug 22, 2014

If using versioned boxes from vagrant cloud and a new update is
published, by default vagrant will attempt to update that box to
the latest version. This may be undesired behaviour. Like any other
versioned object you way wish to fix that initial download to a
fixed version or a version range.

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins Aug 22, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented Aug 22, 2014

Can one of the admins verify this patch?

1 similar comment
@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins Aug 22, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented Aug 22, 2014

Can one of the admins verify this patch?

@@ -28,6 +28,8 @@ def make_vfile hosts, options = {}
v_file << " v.vm.hostname = '#{host.name}'\n"
v_file << " v.vm.box = '#{host['box']}'\n"
v_file << " v.vm.box_url = '#{host['box_url']}'\n" unless host['box_url'].nil?
v_file << " v.vm.box_version = '#{host['box_version']}'\n" unless host['box_version'].nil?
v_file << " v.vm.box_check_update = '#{host['box_check_update'] ||= 'true'}'\n"

This comment has been minimized.

@colinPL

colinPL Sep 12, 2014

Contributor

To be consistent with the other options (similar to v.vm.box_version above), please use unless for this situation.

@colinPL

colinPL Sep 12, 2014

Contributor

To be consistent with the other options (similar to v.vm.box_version above), please use unless for this situation.

This comment has been minimized.

@liamjbennett

liamjbennett Sep 12, 2014

Contributor

As per the vagrant documentation here the box_check_update setting is enabled by default so by setting it to true in this case I am still consistent with the existing default behaviour.

@liamjbennett

liamjbennett Sep 12, 2014

Contributor

As per the vagrant documentation here the box_check_update setting is enabled by default so by setting it to true in this case I am still consistent with the existing default behaviour.

(gh-471) Adding support to vagrant for box_version and box_check_update.
If using versioned boxes from vagrant cloud and a new update is
published, by default vagrant will attempt to update that box to
the latest version. This may be undesired behaviour. Like any other
versioned object you way wish to fix that initial download to a
fixed version or a version range.

anodelman added a commit that referenced this pull request Sep 24, 2014

Merge pull request #418 from liamjbennett/vagrant_box_update
Adding support to vagrant for box_version and box_check_update.

@anodelman anodelman merged commit decdb05 into puppetlabs:master Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment