New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a utility method for configuring the puppet.conf file #419

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@liamjbennett
Contributor

liamjbennett commented Aug 22, 2014

There are many use cases for this, testing non-standard puppet
installations, testing switching environments etc.

Adding a utility method for configuring the puppet.conf file on a given
host using a given hash.

There are many usecases for this, testing non-standard puppet
installations, testing switching environments etc.
@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins Aug 22, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented Aug 22, 2014

Can one of the admins verify this patch?

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins

puppetlabs-jenkins Aug 22, 2014

Contributor

Can one of the admins verify this patch?

Contributor

puppetlabs-jenkins commented Aug 22, 2014

Can one of the admins verify this patch?

liamjbennett added some commits Aug 22, 2014

Adding a utility method for configuring the puppet.conf file on a given
host using a given hash.

There are many usecases for this, testing non-standard puppet
installations, testing switching environments etc.
@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Sep 24, 2014

Contributor

test this please

Contributor

anodelman commented Sep 24, 2014

test this please

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins
Contributor

puppetlabs-jenkins commented Sep 24, 2014

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Sep 24, 2014

Contributor

Failures:

  1. ClassMixedWithDSLInstallUtils configure_puppet on windows it sets the puppet.conf file to the provided config
    Failure/Error: subject.configure_puppet(host, config)
    NoMethodError:
    undefined method `powershell' for #ClassMixedWithDSLInstallUtils:0x7f17870efc40

    ./lib/beaker/dsl/install_utils.rb:678:in`configure_puppet'

    ./spec/beaker/dsl/install_utils_spec.rb:517

Contributor

anodelman commented Sep 24, 2014

Failures:

  1. ClassMixedWithDSLInstallUtils configure_puppet on windows it sets the puppet.conf file to the provided config
    Failure/Error: subject.configure_puppet(host, config)
    NoMethodError:
    undefined method `powershell' for #ClassMixedWithDSLInstallUtils:0x7f17870efc40

    ./lib/beaker/dsl/install_utils.rb:678:in`configure_puppet'

    ./spec/beaker/dsl/install_utils_spec.rb:517

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Nov 4, 2014

Contributor

retest this please

Contributor

anodelman commented Nov 4, 2014

retest this please

@puppetlabs-jenkins

This comment has been minimized.

Show comment
Hide comment
@puppetlabs-jenkins
Contributor

puppetlabs-jenkins commented Nov 4, 2014

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Nov 10, 2014

Contributor

Please repair spec tests.

Contributor

anodelman commented Nov 10, 2014

Please repair spec tests.

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Nov 17, 2014

Contributor

Needs rebase.

Contributor

anodelman commented Nov 17, 2014

Needs rebase.

liamjbennett added some commits Aug 22, 2014

Adding a utility method for configuring the puppet.conf file on a given
host using a given hash.

There are many usecases for this, testing non-standard puppet
installations, testing switching environments etc.
Adding a utility method for configuring the puppet.conf file on a given
host using a given hash.

There are many usecases for this, testing non-standard puppet
installations, testing switching environments etc.
@liamjbennett

This comment has been minimized.

Show comment
Hide comment
@liamjbennett

liamjbennett Nov 17, 2014

Contributor

Damn it. I think I messed up this merge. Will close and reopen changes.

Contributor

liamjbennett commented Nov 17, 2014

Damn it. I think I messed up this merge. Will close and reopen changes.

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Dec 1, 2014

Contributor

Shall we close this in favor of a new PR?

Contributor

anodelman commented Dec 1, 2014

Shall we close this in favor of a new PR?

@anodelman

This comment has been minimized.

Show comment
Hide comment
@anodelman

anodelman Jan 12, 2015

Contributor

Last comment still current.

Contributor

anodelman commented Jan 12, 2015

Last comment still current.

@liamjbennett

This comment has been minimized.

Show comment
Hide comment
@liamjbennett

liamjbennett Jan 19, 2015

Contributor

Closed in favor of #634

Contributor

liamjbennett commented Jan 19, 2015

Closed in favor of #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment