New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(QE-204) allow for use of local vagrant file when using --no-provision #48

Merged
merged 2 commits into from Nov 19, 2013

Conversation

Projects
None yet
3 participants
@anodelman
Copy link
Contributor

anodelman commented Oct 30, 2013

  • use already set up vagrant boxes when running with --no-provision

Workflow:

  1. initial setup of vagrant machines
    bundle exec beaker --config vagrant.cfg --preserve-hosts
  2. use those same hosts on the next run
    bundle exec beaker --config vagrant.cfg --preserve-hosts --no-provision
hack_etc_hosts @vagrant_hosts
hack_etc_hosts @vagrant_hosts
else
#we are using previsouly set up vagrant boxes, just need to set up ssh correctly

This comment has been minimized.

@justinstoller

justinstoller Oct 31, 2013

Member

Why is this an else? Don't we need to do this for newly created boxes as well?

@@ -24,7 +24,7 @@ def initialize(options, logger)
# - only if we are running with --provision
# - only if we have a hypervisor
# - only if either the specific hosts has no specification or has 'provision' in its config
if @options[:provision] && hypervisor && (host_info.has_key?('provision') ? host_info['provision'] : true) #obey config file provision, defaults to provisioning vms
if (@options[:provision] && hypervisor && (host_info.has_key?('provision') ? host_info['provision'] : true)) or (hypervisor =~ /vagrant/) #obey config file provision, defaults to provisioning vms

This comment has been minimized.

@justinstoller

justinstoller Oct 31, 2013

Member

Can we break this out into something more understandable?

anodelman added some commits Oct 29, 2013

(QE-204) allow for use of local vagrant file when using --no-provision
- use already set up vagrant boxes when running with --no-provision
@pcarlisle

This comment has been minimized.

Copy link
Contributor

pcarlisle commented Nov 13, 2013

Is there a reason this is still waiting?

@anodelman

This comment has been minimized.

Copy link
Contributor

anodelman commented Nov 13, 2013

Blocked on secondary review.

justinstoller added a commit that referenced this pull request Nov 19, 2013

Merge pull request #48 from anodelman/fix-vagrant
(QE-204) allow for use of local vagrant file when using --no-provision

@justinstoller justinstoller merged commit 1959b6f into puppetlabs:master Nov 19, 2013

1 check passed

default The Travis CI build passed
Details

hunner added a commit to hunner/beaker that referenced this pull request Nov 20, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

hunner added a commit to hunner/beaker that referenced this pull request Nov 20, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

hunner added a commit to hunner/beaker that referenced this pull request Nov 21, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

hunner added a commit to hunner/beaker that referenced this pull request Nov 21, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

hunner added a commit to hunner/beaker that referenced this pull request Nov 21, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

hunner added a commit to hunner/beaker that referenced this pull request Nov 21, 2013

Destroy vagrant hosts only if Vagrantfile exists
The new `vagrant destroy --force` run during the vagrant hypervisors
`provision` method added in puppetlabs#48 seems to fail if no `Vagrantfile` has
ever been created for a nodeset. This fixes that.

@anodelman anodelman deleted the anodelman:fix-vagrant branch Nov 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment