Destroy vagrant hosts only if Vagrantfile exists #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update spec tests. |
|
|
||
| it "destroys an existing set of hosts before provisioning" do | ||
| File.stub(:file?).and_return('/tmp/nodeset.yml') | ||
| vagrant.should_receive( :vagrant_cmd ).with( "destroy --force" ).once |
There was a problem hiding this comment.
We are using FakeFS for file functions in our spec tests. Can you do a quick re-write with that?
The new `vagrant destroy --force` run during the vagrant hypervisors `provision` method added in voxpupuli#48 seems to fail if no `Vagrantfile` has ever been created for a nodeset. This fixes that.
anodelman
added a commit
that referenced
this pull request
Nov 21, 2013
Destroy vagrant hosts only if Vagrantfile exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
vagrant destroy --forcerun during the vagrant hypervisorsprovisionmethod added in #48 seems to fail if noVagrantfilehas ever been created for a nodeset. This fixes that.