Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target group globbing #2818

Closed
breca opened this issue May 6, 2021 · 3 comments · Fixed by #3137
Closed

Target group globbing #2818

breca opened this issue May 6, 2021 · 3 comments · Fixed by #3137
Labels
Feature New features and improvements.

Comments

@breca
Copy link
Contributor

breca commented May 6, 2021

Use Case

I would like to be able to glob target groups

Describe the Solution You Would Like

bolt inventory show --targets group:'foo*'
bolt command run 'echo "Bolt is great"' -t group:'*bar*'

Describe Alternatives You've Considered

Creating groups of groups, which is nice on paper but can become a bit painful when dealing with dynamic inventories at large scales

Additional Context

Add any other context or screenshots about the feature request here.

@breca breca added the Feature New features and improvements. label May 6, 2021
@reidmv
Copy link
Contributor

reidmv commented Sep 13, 2021

Suggestion:

No need to include a group: prefix. The Bolt inventory already knows group names, in addition to target names, and treats them identically for almost all other interfaces except for globbing. So, globbing shouldn't be special. Make globbing work for and find group names in addition to target names. It should work exactly as it already does for targets, just match group names as well.

@breca
Copy link
Contributor Author

breca commented Sep 28, 2021

Yeah I suppose I threw the prefix in as I think having the capability to have the distinction between nodes and groups is useful
i.e explicitly prevent users from inadvertently globbing nodes when they want to operate on groups only
But both would be nice 😄

beechtom added a commit to beechtom/bolt that referenced this issue Jul 27, 2022
This updates the inventory to support globbing group names in addition
to target names and aliases.

!feature

* **Support globbing group names**
  ([puppetlabs#2818](puppetlabs#2818))

  Bolt now supports selecting group names with glob patterns when
  selecting targets.
beechtom added a commit to beechtom/bolt that referenced this issue Jul 28, 2022
This updates the inventory to support globbing group names in addition
to target names and aliases.

!feature

* **Support globbing group names**
  ([puppetlabs#2818](puppetlabs#2818))

  Bolt now supports selecting group names with glob patterns when
  selecting targets.
@github-actions
Copy link

This issue has not had activity for 60 days and will be marked as stale.
If this issue continues to have no activity for 7 days, it will be closed.

@github-actions github-actions bot added the Stale Issues and PRs that haven't had activity in 60 days. label Jul 29, 2022
@beechtom beechtom linked a pull request Jul 29, 2022 that will close this issue
@beechtom beechtom removed the Stale Issues and PRs that haven't had activity in 60 days. label Jul 29, 2022
beechtom added a commit to beechtom/bolt that referenced this issue Aug 2, 2022
This updates the inventory to support globbing group names in addition
to target names and aliases.

!feature

* **Support globbing group names**
  ([puppetlabs#2818](puppetlabs#2818))

  Bolt now supports selecting group names with glob patterns when
  selecting targets.
beechtom added a commit that referenced this issue Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New features and improvements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants