(GH-2652) Support Puppet paths in 'bolt script run' #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using Puppet paths (`<MODULE NAME>/<FILE NAME>`) in `bolt script run` and `Invoke-BoltScript`. The default behavior is to still locate the script file using an absolute/relative path, but Bolt will now fall back to checking if the path is a Puppet path if that fails. !feature * **Support Puppet paths when running scripts from the CLI** ([puppetlabs#2652](puppetlabs#2652)) You can now use Puppet paths (`<MODULE NAME>/<FILE NAME>`) to specify the path to a script when running `bolt script run` or `Invoke-BoltScript`.
beechtom
force-pushed
the
2652/script-path
branch
from
4329372
to
b534945
Compare
lucywyman
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Nice!
- Finds files from the builtin modulepath
- Finds files from the user-defined modulepath
- Errors if the script isn't in the module (with a very fancy path even!)
- Errors if the script is in the module but isn't under
files/ - Errors if the script is unreadable (ie. owned by another user with 600 permissions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using Puppet paths (
<MODULE NAME>/<FILE NAME>)in
bolt script runandInvoke-BoltScript. The default behavior is tostill locate the script file using an absolute/relative path, but Bolt
will now fall back to checking if the path is a Puppet path if that
fails.
!feature
Support Puppet paths when running scripts from the CLI
(#2652)
You can now use Puppet paths (
<MODULE NAME>/<FILE NAME>) to specifythe path to a script when running
bolt script runorInvoke-BoltScript.