From 2c4a6e1b4a2d85dea25e7b7ac06e9a6c8b9e3cb3 Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Tue, 6 Aug 2019 14:29:25 +0300 Subject: [PATCH 1/6] (FACT-1953) Include all files in lib folder for test coverage. --- spec/facter/{fact_loader_test.rb => fact_loader_spec.rb} | 2 +- spec/spec_helper.rb | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) rename spec/facter/{fact_loader_test.rb => fact_loader_spec.rb} (92%) diff --git a/spec/facter/fact_loader_test.rb b/spec/facter/fact_loader_spec.rb similarity index 92% rename from spec/facter/fact_loader_test.rb rename to spec/facter/fact_loader_spec.rb index b9dfc36c9..426ed3034 100644 --- a/spec/facter/fact_loader_test.rb +++ b/spec/facter/fact_loader_spec.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -describe '.load facts for OS' do +RSpec.describe '.load facts for OS' do it 'load one fact' do allow_any_instance_of(Module).to receive(:constants).and_return([:NetworkInterface]) fact_hash = Facter::FactLoader.load(:linux) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 4c8d5e536..42e6d88bf 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,7 +6,10 @@ require 'bundler/setup' require_relative '../lib/fact_loader' require_relative '../lib/facts/linux/network_interface' -require_relative 'facter/fact_loader_test' + +SimpleCov.start do + track_files 'lib/**/*.rb' +end RSpec.configure do |config| # Enable flags like --only-failures and --next-failure From 7e0d53410e8e237fe3fb4b31022c3ba6a624c7d5 Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Tue, 6 Aug 2019 17:52:40 +0300 Subject: [PATCH 2/6] (FACT-1953) Set code coverage lower limit. --- spec/spec_helper.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 42e6d88bf..992b1444c 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,6 +11,8 @@ track_files 'lib/**/*.rb' end +SimpleCov.minimum_coverage 90 + RSpec.configure do |config| # Enable flags like --only-failures and --next-failure config.example_status_persistence_file_path = '.rspec_status' From f9fe1618570d31bbb1a6614a7e9c20dc45a64274 Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Tue, 6 Aug 2019 17:57:29 +0300 Subject: [PATCH 3/6] (FACT-1953) Change coverage limit to 10 % --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 992b1444c..e137fe5b6 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,7 +11,7 @@ track_files 'lib/**/*.rb' end -SimpleCov.minimum_coverage 90 +SimpleCov.minimum_coverage 10 RSpec.configure do |config| # Enable flags like --only-failures and --next-failure From 1b98b5cf928e5785fbfb2dda8b86da8f6567e93e Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Wed, 7 Aug 2019 08:48:30 +0300 Subject: [PATCH 4/6] Add space --- spec/spec_helper.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index e137fe5b6..43720df9f 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -24,3 +24,4 @@ c.syntax = :expect end end + From ca3c6a6d5cfa0e847f192c46cdf236eda10bec90 Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Wed, 7 Aug 2019 08:52:31 +0300 Subject: [PATCH 5/6] Remove space --- spec/spec_helper.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 43720df9f..e137fe5b6 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -24,4 +24,3 @@ c.syntax = :expect end end - From 37a24cfaa0642fb1327fcc10c90ca66abe145fb7 Mon Sep 17 00:00:00 2001 From: Bogdan Irimie Date: Wed, 7 Aug 2019 08:55:14 +0300 Subject: [PATCH 6/6] Add space. --- spec/spec_helper.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index e137fe5b6..43720df9f 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -24,3 +24,4 @@ c.syntax = :expect end end +