New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1709) Add support for memory fact on FreeBSD #1593

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
3 participants
@smortex
Contributor

smortex commented Jul 8, 2017

The structure was copied from the OpenBSD resolver, adjusted to collect information through FreeBSD's sysctl interface.

@smortex smortex force-pushed the smortex:freebsd-memory_resolver branch from 436628a to b0af7e4 Jul 8, 2017

@puppetcla

This comment has been minimized.

puppetcla commented Jul 8, 2017

CLA signed by all contributors.

@smortex smortex force-pushed the smortex:freebsd-memory_resolver branch from b0af7e4 to 4eb5736 Jul 10, 2017

@smortex smortex changed the title from (FACT-1677) Add support for memory fact on FreeBSD to (FACT-1709) Add support for memory fact on FreeBSD Jul 10, 2017

@Magisus

This comment has been minimized.

Contributor

Magisus commented Jul 11, 2017

What does your FreeBSD development environment look like? I was trying to build this to try it out and ran into problems compiling Leatherman. You clearly got it working; what OS, compiler, and Boost versions were you using?

@smortex

This comment has been minimized.

Contributor

smortex commented Jul 12, 2017

@Magisus I am running FreeBSD 11.0-STABLE and tested all changes with #1594, #1595, #1596, #1597, #1598 and #1599 combined on FreeBSD 10.3-RELEASE and 11.0-RELEASE.

In all cases, I build with system's cc (clang) and boost-libs version is 1.64.0.

leatherman is compiled with -DLEATHERMAN_SHARED:BOOL=ON and two patches that have been arround in the FreeBSD port for some time : 1 (remove -Werror flag), 2 (LTH-118, aka puppetlabs/leatherman#213).


If you are interested in more details:


Please let me know if you need more details. Thanks!

@Magisus

This all looks right to me.

@puppetcla

This comment has been minimized.

puppetcla commented Jul 20, 2017

CLA signed by all contributors.

@smortex smortex force-pushed the smortex:freebsd-memory_resolver branch from 4de48d2 to 67d656d Jul 20, 2017

(FACT-1709) Add support for memory fact on FreeBSD
```
% uname
FreeBSD
% ./bin/facter memory
{
  swap => {
    available => "7.76 GiB",
    available_bytes => 8335601664,
    capacity => "2.96%",
    total => "8.00 GiB",
    total_bytes => 8589795328,
    used => "242.42 MiB",
    used_bytes => 254193664
  },
  system => {
    available => "6.74 GiB",
    available_bytes => 7232036864,
    capacity => "57.79%",
    total => "15.96 GiB",
    total_bytes => 17133985792,
    used => "9.22 GiB",
    used_bytes => 9901948928
  }
}
```

@smortex smortex force-pushed the smortex:freebsd-memory_resolver branch from 67d656d to 82495a3 Jul 20, 2017

@Magisus Magisus merged commit b3b832b into puppetlabs:master Jul 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.43%
Details

@smortex smortex deleted the smortex:freebsd-memory_resolver branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment