New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1710) Support zfs/zpool facts on FreeBSD #1595

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@smortex
Contributor

smortex commented Jul 10, 2017

These changes where stolen from the solaris implementation.

(FACT-1710) Support zfs/zpool facts on FreeBSD
These changes where stolen from the solaris implementation.
@puppetcla

This comment has been minimized.

puppetcla commented Jul 10, 2017

CLA signed by all contributors.

@Magisus

This comment has been minimized.

Contributor

Magisus commented Jul 18, 2017

Since these are exactly the same as the Solaris implementation, might there be a way to use the same implementation for both? I'm not sure what the common denominator would be and how to fit that into our directory structure? /cc @MikaelSmith

On the flip side, @smortex can you think of any reason why the two implementations might diverge at some point?

@Magisus

After discussion with @branan, the is probably fine as is. The duplicated code is very short.

@MikaelSmith MikaelSmith merged commit 39ccf89 into puppetlabs:master Jul 19, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.43%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment