New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1713) Add support for FreeBSD jails virtualization resolution #1598

Merged
merged 2 commits into from Jul 20, 2017

Conversation

Projects
None yet
3 participants
@smortex
Contributor

smortex commented Jul 10, 2017

No description provided.

@smortex smortex changed the title from (FACT-1713) Add support for FreeBSD jails to (FACT-1713) Add support for FreeBSD jails virtualization resolution Jul 10, 2017

@puppetcla

This comment has been minimized.

puppetcla commented Jul 10, 2017

CLA signed by all contributors.

@puppetcla

This comment has been minimized.

puppetcla commented Jul 20, 2017

CLA signed by all contributors.

@Magisus

This comment has been minimized.

Contributor

Magisus commented Jul 20, 2017

We are doing work around changing the way that Facter does virtualization detection (see https://github.com/puppetlabs/libwhereami). Eventually we might be able to update this to use that library, but for now this looks fine to me.

@Magisus Magisus merged commit e078dcb into puppetlabs:master Jul 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.43%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment