New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-1714) Use posix::operating_system_resolver for bsd, freebsd and openbsd #1599

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@smortex
Contributor

smortex commented Jul 10, 2017

*BSD are basically POSIX compliant systems, so rely on posix::operating_system_resolver instead of resolvers::operating_system_resolver to resolve Operating System facts.

This makes some facts previously visible in the Ruby version of Facter usable again with the C++ version of Facter.

(FACT-1714) Use posix::operating_system_resolver
*BSD are basically POSIX compliant systems, so rely on
posix::operating_system_resolver instead of
resolvers::operating_system_resolver to resolve Operating System facts.

This makes some facts previously visible in the Ruby version of Facter
usable again with the C++ version of Facter.

@smortex smortex changed the title from (FACT-1714) Use posix::operating_system_resolver to (FACT-1714) Use posix::operating_system_resolver for bsd, freebsd and openbsd Jul 10, 2017

@puppetcla

This comment has been minimized.

puppetcla commented Jul 10, 2017

CLA signed by all contributors.

@Magisus Magisus merged commit b84e393 into puppetlabs:master Jul 21, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.43%
Details

@smortex smortex deleted the smortex:improve-posix-operating_system_resolver branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment