Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-867) Port xendomains fact #997

Merged
merged 1 commit into from Jun 30, 2015

Conversation

@MikaelSmith
Copy link
Member

MikaelSmith commented Jun 26, 2015

Re-implements the xendomains fact in Facter 3.

@MikaelSmith MikaelSmith changed the title (FACT-867) Port xendomains fact WIP (FACT-867) Port xendomains fact Jun 26, 2015
@MikaelSmith MikaelSmith force-pushed the MikaelSmith:bug/stable/FACT-867 branch from 84f7030 to 0a5f7b6 Jun 26, 2015
@MikaelSmith MikaelSmith changed the title WIP (FACT-867) Port xendomains fact (FACT-867) Port xendomains fact Jun 26, 2015
@MikaelSmith MikaelSmith force-pushed the MikaelSmith:bug/stable/FACT-867 branch from 0a5f7b6 to f735036 Jun 26, 2015
@puppetcla

This comment has been minimized.

Copy link

puppetcla commented Jun 27, 2015

CLA signed by all contributors.

@MikaelSmith MikaelSmith force-pushed the MikaelSmith:bug/stable/FACT-867 branch from f735036 to 3e1d0be Jun 27, 2015
@peterhuene

This comment has been minimized.

Copy link
Contributor

peterhuene commented Jun 29, 2015

Looks like there are legitimate build failures in Travis.

@peterhuene peterhuene added the PL label Jun 29, 2015
@MikaelSmith MikaelSmith force-pushed the MikaelSmith:bug/stable/FACT-867 branch from 3e1d0be to 6241cef Jun 29, 2015
@MikaelSmith

This comment has been minimized.

Copy link
Member Author

MikaelSmith commented Jun 29, 2015

Manually verified that if the system looks like we expect a xen0 machine to look, it should work.

if (success) {
return output;
} else {
LOG_DEBUG("failure executing %1%: %2%", xen_toolstack, error);

This comment has been minimized.

Copy link
@peterhuene

peterhuene Jun 30, 2015

Contributor

If xen-toolstack fails, should we fallback to xl/xm or not?

This comment has been minimized.

Copy link
@MikaelSmith

MikaelSmith Jun 30, 2015

Author Member

I followed the original logic that said no. I'm open to argument, but not sure what the case is for having xen-toolstack installed.

This comment has been minimized.

Copy link
@peterhuene

peterhuene Jun 30, 2015

Contributor

👍 for parity.

}
return true;
}, [&](string& line) {
LOG_DEBUG("output on stderr running %1% list: %2%", command, line);

This comment has been minimized.

Copy link
@peterhuene

peterhuene Jun 30, 2015

Contributor

I think you can pass in nullptr (or omit the stderr callback as nullptr is the default) and it'll default to redirecting stderr to null when not debug level and automatically output the stderr lines (prefixed with !!! instead of |) when debug level.

This comment has been minimized.

This comment has been minimized.

Copy link
@MikaelSmith

MikaelSmith Jun 30, 2015

Author Member

Ah right, forgot that was there.

Re-implements the xendomains fact in Facter 3.
@MikaelSmith MikaelSmith force-pushed the MikaelSmith:bug/stable/FACT-867 branch from 6241cef to ca30fb3 Jun 30, 2015
@peterhuene

This comment has been minimized.

Copy link
Contributor

peterhuene commented Jun 30, 2015

👍 will merge after CI.

peterhuene added a commit that referenced this pull request Jun 30, 2015
(FACT-867) Port xendomains fact
@peterhuene peterhuene merged commit a58c4d5 into puppetlabs:stable Jun 30, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.15%) to 85.32%
Details
@MikaelSmith MikaelSmith deleted the MikaelSmith:bug/stable/FACT-867 branch Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.