Add Debian 11 support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you remove the RedHat mocking in https://github.com/puppetlabs/influxdb/blob/main/spec/classes/init_spec.rb#L4 ? |
|
I saw that and thought it looked wrong too. Removed. |
kenyon
force-pushed
the
debian11
branch
2 times, most recently
from
b4284d6
to
b5fe9ab
Compare
bastelfreak
reviewed
Sep 7, 2023
kenyon
force-pushed
the
debian11
branch
2 times, most recently
from
210b2b7
to
8785444
Compare
Debian was maybe mistakenly removed in puppetlabs#78.
kenyon
force-pushed
the
debian11
branch
2 times, most recently
from
941ed18
to
f40b857
Compare
They have an ubuntu directory, so we should use it.
|
@bastelfreak maybe there is a better way to handle the different operating systems in the spec tests, but this at least runs tests with the facts for each OS now! Easiest to review one commit at a time. |
|
That AlmaLinux failure looks unrelated, let's try running the tests again... |
|
@m0dular we good to merge this? |
|
I meant to only rerun the Alma test, but accidentally kicked them all off again. I think we should be good to merge this regardless of that test, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes #102.