Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use token file on disk to fetch tokens #17

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Mar 9, 2022

This commit changes the retrieve_token() function to use an admin token
on disk. This allows it to be used as a deferred function where it will
be run on agents instead of the primary server.

Also fixes an issue where Dir.home would throw an error when running via
a service.

@m0dular m0dular requested a review from a team as a code owner March 9, 2022 22:52
@puppet-community-rangefinder
Copy link

influxdb::retrieve_token is a function

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

This commit changes the retrieve_token() function to use an admin token
on disk.  This allows it to be used as a deferred function where it will
be run on agents instead of the primary server.

Also fixes an issue where Dir.home would throw an error when running via
a service.
@MartyEwings MartyEwings added the enhancement New feature or request label Mar 10, 2022
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work and cause no ill effects,

I assume we have to modify operational dashboards to consume this?

@m0dular
Copy link
Contributor Author

m0dular commented Mar 10, 2022

Yes, we'll use it with Deferred so that agents can use it during catalog application.

@m0dular m0dular merged commit 6850c70 into puppetlabs:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants