Skip to content

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Mar 10, 2022

This commit checks if the admin_token_file exists on disk before reading
it in the retrieve_token() function.

This commit checks if the admin_token_file exists on disk before reading
it in the retrieve_token() function.
@m0dular m0dular added the bug Something isn't working label Mar 10, 2022
@m0dular m0dular requested a review from a team as a code owner March 10, 2022 18:41
@puppet-community-rangefinder
Copy link

influxdb::retrieve_token is a function

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the code that use this function handle a nil/undef result? You may have to return a default string.

@m0dular
Copy link
Contributor Author

m0dular commented Mar 10, 2022

It does, in the sense that it will create a Sensitive[undef] value. That causes the Telegraf override file and the Grafana datasource to use an empty token, which I guess is the expected behavior?

@jarretlavallee
Copy link
Contributor

Sounds good.

@m0dular
Copy link
Contributor Author

m0dular commented Mar 10, 2022

Centos 7 was hung on "Installing PE" for about 40 minutes, so I killed it.

m0dular added 2 commits March 10, 2022 12:42
This is needed to use it with an inline_epp function.
@m0dular m0dular merged commit edf665c into puppetlabs:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants