Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an option to disable installing from source #29

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

vchepkov
Copy link
Contributor

No description provided.

@vchepkov vchepkov requested a review from a team as a code owner August 15, 2022 14:12
@puppet-community-rangefinder
Copy link

influxdb is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular
Copy link
Contributor

m0dular commented Aug 15, 2022

Good catch, thank you @vchepkov! We have a changelog generator that will actually update REFERENCE.md when we do a release, so could you remove the change to it in this PR? Then I think we'll be good to merge this.

I'll also add a test to cover the combinations of $manage_repo and $archive_source.

@vchepkov
Copy link
Contributor Author

Certainly, I will update description of the parameter instead

@vchepkov
Copy link
Contributor Author

Done

@m0dular
Copy link
Contributor

m0dular commented Aug 15, 2022

Failures are due to SLES 15 not having netstat, which the Serverspec tests use behind the scenes. I'll make the same change as here in the spec test PR, which I'll make later today.

Thanks again for using and contributing!

@m0dular m0dular merged commit a55d3d8 into puppetlabs:main Aug 15, 2022
@vchepkov
Copy link
Contributor Author

@m0dular , unfortunately, this brought up another defect - service influxdb is only defined if configured via yumrepo or achive_source. Imho, it should be out of both blocks

@m0dular m0dular added the enhancement New feature or request label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants