Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-3557) Add spec tests for the main class #32

Merged
merged 3 commits into from
Aug 15, 2022
Merged

(SUP-3557) Add spec tests for the main class #32

merged 3 commits into from
Aug 15, 2022

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Aug 15, 2022

No description provided.

@m0dular m0dular requested a review from a team as a code owner August 15, 2022 18:12
@puppet-community-rangefinder
Copy link

influxdb is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

vchepkov
vchepkov reviewed Aug 15, 2022
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
@m0dular m0dular mentioned this pull request Aug 15, 2022
Closed
@m0dular
Remove duplicate service declaration and pry
eb459a3 
Also remove unnecessary require
Sharpie
Sharpie approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@m0dular m0dular merged commit 7fe8b8b into puppetlabs:main Aug 15, 2022
@m0dular m0dular added the enhancement New feature or request label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarretlavallee jarretlavallee jarretlavallee left review comments

@vchepkov vchepkov vchepkov approved these changes

@Sharpie Sharpie Sharpie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m0dular @Sharpie @vchepkov @jarretlavallee