-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a mixin module instead of inheritance #7
Conversation
m0dular
commented
Feb 28, 2022
influxdb::from_toml is a functionthat may have no external impact to Forge modules. influxdb::retrieve_token is a functionthat may have no external impact to Forge modules. influxdb::to_toml is a functionthat may have no external impact to Forge modules. This module is declared in 0 of 578 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with the exception of the commented out code parts.
I also updated my original Pull for testing to add in the missing fixture, I'm not sure if you have to replay that commit over the top of this or not
1029a6c
to
48004e8
Compare
Prior to this commit, the module used a Puppet class to instantiate a base provider for the other providers to inherit. However, this caused issues when using the 'require' metaparameter in manifests, because Puppet may not have autoloaded the base type yet. It was also overly complicated. This commit moves this functionality to a shared module which uses constants and instance methods, which is a simpler design. This removes the need for the Puppet wrapper class, and the user does not need to require anything to use the types.
1decccc
to
d1c1333
Compare
|
Cancelled the tests since it was just a squash. |