Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install toml-rb gem inside puppet agent #75

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

vchepkov
Copy link
Contributor

@vchepkov vchepkov commented Mar 11, 2023

prior to this commit, puppet commands like apply, lookup --compile would fail on puppet agent with module enabled

@vchepkov vchepkov requested a review from a team as a code owner March 11, 2023 12:49
@puppet-community-rangefinder
Copy link

influxdb::profile::toml is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

prior to this commit, puppet commands like apply, lookup --compile would fail on puppet agent
with module enabled
@m0dular
Copy link
Contributor

m0dular commented Mar 13, 2023

Looks great @vchepkov , my only question is if the puppet service needs to be restarted after installing the gem? I would assume no, but I'm not sure if the service reloads the gems every time it runs or on startup.

@vchepkov
Copy link
Contributor Author

I don't think so, it only affects 'user' commands

@m0dular
Copy link
Contributor

m0dular commented Mar 13, 2023

That makes sense given puppet apply and puppet lookup --compile need to compile a catalog locally.

@m0dular m0dular added the enhancement New feature or request label Mar 13, 2023
@m0dular m0dular merged commit ab85768 into puppetlabs:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants