(LTH-130) Use rapidjson 1.1.0 #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocking work:
|
rapidjson is no longer vendored, it must be installed on the system independently.
MikaelSmith
force-pushed
the
rapidjson-1.1.0
branch
from
4f9ba78
to
0ed6a7b
Compare
|
CLA signed by all contributors. |
|
This would be nice in order to be able to build facter with XCode 9.3 on OS X XCode 9.3 barfs on building rapidjson 1.0.2, but there's a fix in 1.1.0: Tencent/rapidjson@ee4207b |
smortex
reviewed
Jan 10, 2019
| @@ -1,11 +1,11 @@ | |||
| find_package(Boost 1.54 REQUIRED COMPONENTS regex) | |||
| find_package(rapidjson 1.1.0 REQUIRED) | |||
There was a problem hiding this comment.
The file is named RapidJSON upstream:
https://github.com/Tencent/rapidjson/blob/master/RapidJSON.pc.in
This seems to be causing the failures…
|
any change to get this done? |
|
Closed in favor of #289. I'm not actively working on the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidjson is no longer vendored, it must be installed on the system
independently.