(LTH-130) Unvendor RapidJSON

[smortex]

This is an attempt of extracting RapidJSON from the leatherman archive.

Work was started in #265 by @MikaelSmith but not finished. Take his work, rebase on top of master, add a fix and see what happens 😉

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[smortex]

Yay! After a few hours of pain, it's all green 😌

@MikaelSmith, because of divergences, I had to change the way RapidJSON is made available during the rebase. For build on UNIX-like systems, I chose to install the rapidjson-dev package which contains all required parts:

leatherman/.travis.yml

Line 11 in 73f08a5

apk add --no-cache rapidjson-dev &&

For windows, I chose to grab the source code, and use the "regular" (?) build tools to do what I think is equivalent to ./configure && make && make install:

leatherman/appveyor.yml

Lines 16 to 23 in 73f08a5

	cd C:\projects
	curl --location -o v1.1.0.zip https://github.com/Tencent/rapidjson/archive/v1.1.0.zip
	7z.exe x v1.1.0.zip
	cd rapidjson-1.1.0
	cmake .
	msbuild /P:Configuration=Release RapidJSON.sln
	msbuild /P:Configuration=Release INSTALL.vcxproj
	cd C:\projects\leatherman

Please tell me if you mind, and I'll try to amend this commit to separate what you wrote from what I wrote.

The other changes are I guess straightforward.

This is ready for review, and could replace #265 and #287!

[puppetcla]

CLA signed by all contributors.

[MikaelSmith]

These changes make sense. They have some implications for downstream users. I think we (Puppet) will want to add a pre-compiled rapidjson to our myget feed.

[smortex]

I think we (Puppet) will want to add a pre-compiled rapidjson to our myget feed.

That look like a good idea, however, I don't know how to help to make this happen.

Similarly, adding rapidjson-dev directly to the docker image used may make sense. I found what I suspect to be the Dockerfile of this image yesterday, if you think it makes sense, I can open a Pull-Request to do so?

Thanks!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ smortex
❌ MikaelSmith
_{You have signed the CLA already but the status is still pending? Let us recheck it.}