Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(LTH-163) Call ruby_sysinit to initialize Windows sockets #298

Merged

Conversation

@GabrielNagy
Copy link
Member

GabrielNagy commented Aug 2, 2019

Ruby >= 2.5 has changed how the Windows sockets are started (see: ruby/ruby@e33b169), requiring a call to rb_w32_sysinit for starting them.

Not having this call causes segmentation faults when querying custom facts that use Windows Sockets with Ruby versions 2.5 and higher.

Ruby >= 2.5 has changed how the Windows sockets are started (see:
ruby/ruby@e33b169), requiring a call to rb_w32_sysinit for starting
them.

Not having this call causes segmentation faults when querying custom
facts that use Windows Sockets with Ruby versions 2.5 and higher.
@mihaibuzgau mihaibuzgau requested a review from puppetlabs/night-s-watch Aug 2, 2019
@puppetcla

This comment has been minimized.

Copy link

puppetcla commented Aug 2, 2019

CLA signed by all contributors.

ruby/src/api.cc Show resolved Hide resolved
@ciprianbadescu ciprianbadescu merged commit 99aeac6 into puppetlabs:1.5.x Aug 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.