Skip to content
This repository has been archived by the owner. It is now read-only.

(CPR-397) explicitly pin to a working version of Rainbow #12

Merged
3 commits merged into from Dec 28, 2016

Conversation

@mckern
Copy link
Contributor

mckern commented Dec 27, 2016

lock_manager depends on rubocop, which in turn requires rainbow. The explicit dependency is versioned, but the transitive dependency is not. rainbow recently pushed a broken 2.2.0 release, which is impacting our ability to get work done because anything that tries to install lock_manager fails. This PR addresses that, as well as updates some of the bootstrapping around Rakefile to ease releasing new versions.

mckern added 3 commits Dec 27, 2016
The Gemspec now correctly references the Gemspec, and the Gemspec no
longer defines developmental dependencies -- that responsibility is
better assigned to the Gemfile.
Rubocop requires rainbow, but without a pinned version. Rainbow 2.2.0
is a broken release (sickill/rainbow#40) so
we should try to insulate users from that pain.
We don't need to explicitly require 'json' -- it's a part of the Ruby
Stdlib. The only real exception is for Ruby 1.9.3, so we should make
its requirement a special exception instead of the rule.

And 'redis' is already provided by the Gemspec so we don't need that
for the development dependencies.
@ghost

This comment has been minimized.

Copy link

ghost commented Dec 28, 2016

🙈

@ghost ghost merged commit 578e0e8 into puppetlabs:master Dec 28, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.