puppetlabs/marionette-collective

MCO-429 2.6.0 release notes and documentation

(MCO-453) Fix validator plugin load race condition

This commit fixes a race condition which occurs when validator plugins
are loaded for the first time by adding a mutex to the Validator
module.

The race condition happens when an agent thread tries to determine
whether it should load the validator plugins, determines that they have
already been loaded by looking at the last_load timestamp but the
validators are in reality still busy loading. By locking the mutex
before the call to #load_validators? we allow
PluginManager.find_and_load to finish before we try and determine if the
validators have been loaded or not.

Conflicts:
	ext/build_defaults.yaml

(MCO-445 & maint) update build defaults

This removes sid and unstable from build_defaults because we no longer
support it.

This commit removes saucy from build_defaults. It went EOL July 17,
2014.

maint - increase required api version to 2.6.0

When implementing MCO-443 we added MCollective::Client.request_sequence and
made use of it in the connectors.  This commit completes this by bumping the
required mcollective api version to 2.6.0, the first version that will have
that new api.

MCO-443 Use a distinct reply queue per request

In very large installations we sometimes will see late discovery
responses arrive on the reply queue after the client has moved on to
expect a response to the subsequent rpc action, as the same reply
queue will be used for all requests made by that process.

Here we avoid this by introducing Client.request_sequence to keep
track of the sequence of requests sent, and use that value to create
a distinct reply queue per request, rather than per process.

Update recommendation for registration to heartbeating

Fix typo in connector_activemq.md

The recommendation to use registration predates having good support for STOMP
1.1 heartbeats in the stomp-gem and our connectors.

Here we rework the Note that outlines what registration does for us in terms of
keeping the connection alive and fault detection, as this also applies to
protocol heartbeats, and move it to the section on connector settings.

Convert release notes examples into docs

This is based on the documentation added to the 2.5.0 release notes

This is based on the documentation added to the 2.4.0 release notes.

This is based on the documentation added to the 2.4.0 release notes.

(MCO-243) Add max duration for soft_shutdown

MCO-175 Document the heartbeat options in the connector pages

This commit takes the information that we added to the release notes
for 2.4.0 and adds them with a little rewording to the reference
pages for the connectors.

This commit adds the soft_shutdown_timeout config variable that is used
to time out the soft shutdown action that is performed by the runner
thread.

This enabled soft_shutdown on Windows when the timeout is set. It will
still revert back to normal shutdown behaviour if the timeout is not
set.

MCO-421 Do signal processing in threads

In ruby 2.0 and onwards it's not permitted to do anything that would
block in a signal handler.  As our control flow doesn't have an
obvious place to process a raised flag, we instead take the approach
of spinning off a new thread to do the processing.

Tested on ruby 2.1.2

MCO-156 - don't set environment variables with the value of nil

Here we change the behaviour of the Shell helper filter the setting of any
environment variables with the value nil.

The initial usecase is the ability to inherit LC_ALL from the environment of
the mcollectived, to achieve this the user would use something like this:

  Shell.new('date', :environment => { 'LC_ALL' => nil })