Update mcollective.init #168

Merged
merged 3 commits into from Mar 11, 2014

Conversation

Projects
None yet
5 participants
Contributor

Reamer commented Mar 5, 2014

In sh the argument -e throws an error.
Snapshot from solaris 10 manual
-e file True if file exists. (Not available
in sh.)

Update mcollective.init
In sh the argument -e throws an error.
Snapshot from solaris 10 manual
     -e file                 True if file exists. (Not  available
                             in sh.)

Waiting for CLA signature by @Reamer

@Reamer - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

Reamer added some commits Mar 5, 2014

Update pkginfo
Correct the NAME from mcollective- to mcollective
+ delete the description in NAME
Update build
With Release param package name from mcollective doesn't confirm the Naming.
You can check the naming with chkcat

https://github.com/dex4er/pkgutil/blob/master/chkcat
Contributor

Reamer commented Mar 5, 2014

my contribution is trivial
Changes in build or installation scripts

Contributor

Reamer commented Mar 11, 2014

Is anything missing? Something I need to know?

Contributor

richardc commented Mar 11, 2014

Dispute about triviality aside, we still need to carefully review any change that comes in and we haven't had the bandwith to do this yet.

Member

haus commented Mar 11, 2014

👍 Looks sane overall.

ploubser added a commit that referenced this pull request Mar 11, 2014

@ploubser ploubser merged commit a87d174 into puppetlabs:master Mar 11, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment