Added :direct_reply target type for activemq subs #49

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

oholiab commented Aug 13, 2012

This creates the listening subscription on the specified queue without
a unique id so that the publishing agent can be initialised using
--reply-to without first setting up the subscriber and replying to the
unique queue id which is created.

Added :direct_reply target type for activemq subs
This creates the listening subscription on the specified queue *without*
a unique id so that the publishing agent can be initialised using
--reply-to without first setting up the subscriber and replying to the
unique queue id which is created.

Waiting for CLA signature by @oholiab

@oholiab - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

CLA signed by all contributors.

Contributor

richardc commented Sep 25, 2013

Given the observation #49 (comment) is this pull request still relevant?

oholiab commented Sep 25, 2013

Probably not, I submitted it about a year ago and forgetting the fact that I've somehow managed to futz up the pull request (sorry again) it's probably against a massively out of date version of the code.

IMO if I (or anyone else) really need this feature it can be resubmitted properly. May as well reject the pull as I'm unlikely to have the chance to rewrite it to a) work b) against the current stable.

Contributor

richardc commented Sep 25, 2013

OK cheers; closing.

@richardc richardc closed this Sep 25, 2013

@oholiab oholiab deleted the oholiab:feature/direct_reply branch Sep 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment